Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove coveralls #395

Merged
merged 5 commits into from
Nov 21, 2024
Merged

[CI] Remove coveralls #395

merged 5 commits into from
Nov 21, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Nov 19, 2024 •
edited by alyssadai
Loading

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

CI:

  • Remove Coveralls integration from the CI workflow.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Nov 19, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR removes Coveralls integration from the CI workflow while maintaining code coverage reporting through Codecov. The changes are implemented by removing the Coveralls-specific steps from the GitHub Actions workflow file while preserving the core testing and coverage generation steps.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Remove Coveralls integration from the CI workflow
  • Remove Coveralls parallel job step configuration
  • Remove Coveralls finish job that was used for parallel coverage reporting
  • Maintain coverage generation and Codecov reporting
 .github/workflows/test.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@surchs surchs added the skip-release PR doesn't appear in the changelog and preserves current version when merged label Nov 19, 2024
sourcery-ai[bot]
sourcery-ai bot reviewed Nov 19, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @surchs - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the 'Changes proposed' section in the PR description to document what is being changed and why Coveralls is being removed.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (0fa03ee) to head (7069157).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   98.36%   98.42%   +0.06%     
==========================================
  Files          18       18              
  Lines         977     1016      +39     
==========================================
+ Hits          961     1000      +39     
  Misses         16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@alyssadai alyssadai self-requested a review November 21, 2024 03:29
alyssadai
alyssadai approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surchs!

🍒 wdyt about using the [CI] prefix for this instead of [MNT]?

@surchs surchs changed the title [MNT] Remove coveralls [CI] Remove coveralls Nov 21, 2024
@surchs surchs merged commit 5694ebe into main Nov 21, 2024
9 checks passed
@surchs surchs deleted the switch_to_codecov branch November 21, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surchs @alyssadai